Update simulator in Makefile to work with Xcode 10.1 default simulator install. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @derekleerock! I noticed while trying to
make alltests
, the tests would not run with my install of Xcode 10.1. It seems to be because all simulators that come with Xcode are running iOS 12.1 butxcodebuild
params specify 12.0.The failure looks like this:
This would probably be fine if I installed simulators running iOS 12.0. Given Xcode 10.1 is the current release version, how do you feel about updating the Makefile? I've also changed the simulator from the iPhone X to the XR - mainly because this is the lowest spec of the current generation (and I think Xcode defaults to it on new projects). That's not strictly necessary to get the tests to run again, though.