New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feh segfaults on jpeg rotation if jpegexiforient is not installed #100

Closed
vesath opened this Issue Sep 27, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@vesath

vesath commented Sep 27, 2012

On an up-to-date Arch Linux system, not having jpegexiforient installed, feh segfaults if I open any jpeg and rotate it by pressing "<".

Here is the relevant GDB output:

feh WARNING: lossless rotate: Failed to exec jpegexiforient: No such file or directory
feh WARNING:
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff6701da8 in vfprintf () from /usr/lib/libc.so.6
(gdb) bt
#0  0x00007ffff6701da8 in vfprintf () from /usr/lib/libc.so.6
#1  0x00007ffff67b0250 in __vsnprintf_chk () from /usr/lib/libc.so.6
#2  0x0000000000409cfc in ?? ()
#3  0x000000000040bb76 in ?? ()
#4  0x000000000040bd7a in ?? ()
#5  0x000000000040f477 in ?? ()
#6  0x000000000040f9d1 in ?? ()
#7  0x0000000000405b3a in ?? ()
#8  0x00007ffff66d8725 in __libc_start_main () from /usr/lib/libc.so.6
#9  0x0000000000405c0d in ?? ()

Indeed, commenting out line 524 of imlib.c "vsnprintf(errstr, 1024, fmt, args);" prevents feh from crashing.

This bug is tracked on Arch Linux there: https://bugs.archlinux.org/task/31699
Although I haven't had the time to go any further than the above yet.

@derf derf closed this in b928208 Sep 27, 2012

@derf

This comment has been minimized.

Owner

derf commented Sep 27, 2012

Whoops. My bad, I forgot a printf argument so feh/imlib got sent into memory nirvana. This issue is fixed in feh 2.6.3.

@vesath

This comment has been minimized.

vesath commented Sep 27, 2012

Thanks a lot for looking into that so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment