Shift modifier doesn't work for some keys

[bruva]

feh version 2.19, minimal example for ~/.config/feh/keys:

next_img
prev_img
next_img space
prev_img S-space

Pressing ⇪+         (space key with shift modifier) does not show the previous image, instead it shows the next image like just pressing space.

For the tab key there is the same problem. I neither can S-Tab nor ISO_Left_Tab (the designation which xev returns) get to work.

[derf]

Yup, this is a bug in the way feh parses key definitions. It uses isascii() to ignore shift modifiers for "normal" keys (as, depending on the keyboard layout, keys like ( ) { } or in rare cases even 0 1 2 ... can also be accessible without Shift). However, isascii() is a bit too broad there. Looks like isgraph() is the better choice.