Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI elements occasionally not reacting to clicks as they should #205

Closed
dermeck opened this issue Apr 2, 2024 · 3 comments
Closed

UI elements occasionally not reacting to clicks as they should #205

dermeck opened this issue Apr 2, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@dermeck
Copy link
Owner

dermeck commented Apr 2, 2024

Clicks on the header button sometime have no effect, they are visually "clicked" but not triggering the action. Clicking Folders collapses/expands them but does not apply a visual style. Drag/Drop still working.

Not sure whats going on there. Maybe related to the "open" state of the MoreMenu which might not always be reset properly.

After switching the Sidebar to Bookmarks and back it works again
(This bug was not noticed in v0.24)

@dermeck dermeck added the bug Something isn't working label Apr 2, 2024
@dermeck dermeck changed the title UI elements occasionally not reacting to clicks as thery should UI elements occasionally not reacting to clicks as they should Apr 2, 2024
@dermeck
Copy link
Owner Author

dermeck commented Apr 2, 2024

Not sure, what's going on here. This might be caused by some dependency upgrade.

There was an error with resize observers, which is ignored: https://github.com/dermeck/feeds-sidebar/pull/198/files#diff-e6b9fb2c431204fadc5f3a9122ac2e93431ad56b38bfa017a9ab29394132418eR60
(might be fixed here https://github.com/petyosi/react-virtuoso/releases/tag/v4.7.7)

Although this should be harmless
petyosi/react-virtuoso#875 (comment)

Might be worth checking if the problem occurs with the old virtuoso version.

@dermeck
Copy link
Owner Author

dermeck commented Apr 3, 2024

CHeck if the issue is caused by non-persistend background script
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Background_scripts#convert_to_non-persistent

@dermeck dermeck mentioned this issue Apr 3, 2024
5 tasks
@dermeck
Copy link
Owner Author

dermeck commented Apr 5, 2024

The problem was the non-persistent background page which caused the state getting lost

@dermeck dermeck closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant