-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date range filters don't work (custom or league) #120
Comments
Heyho! Will check that out, I changed few things for the league filters the last versions, maybe I bricked the Calendar conversion somewhere. Thanks for reporting! |
Hey, sorry dit not forget you. Just nearly no time the last weeks. I will provide you a pre-release testversion the next few days (per discord, we should already be in contact there). |
No worries! It's not a major issue, thanks for following up! |
Hey - were you be able to check again with 1.1.13? Fixed some date calculation issues there. If issue still persists, let me know. I will send you a debug version then... |
I still saw some problems but with a bit more testing I think custom time works correctly as long as I understand that the year I'm setting is in Japanese calendar format and not western. However, for league times, they're always wrong since the years are stored as western dates (2022-2023 etc) but it looks like the app is treating them as Japanese years. (Reiwa 4 - Reiwa 5). I wonder if when we make the leage info objects there is a way to denote that the arguments are in western format (around here Line 1382 in bf6fb5e
Except that that calendar is forced to Gregorian here ( Line 839 in bf6fb5e
The date selector widget is definitely in Japanese calendar format so maybe the problem in writing and reading from the form? I'm not sure how dateTimePicker1/2 is made but maybe at some point the raw gregorian values are being copied but no the calendar... |
Heyho! Coming back to that older issue: Are you still using the Tool? If you still interested in a solution, could you please provide me with the following:
Will try to reproduce the output of the Calendar widget. Thanks! |
If I select any specific league or use custom time range to select any random time frame, it always shows no tracked results.
On the other hand, any relative time period works fine. Last 24 hours, 30 days etc all shows the expected content.
I know in the past there were timestamp problems but think they were supposed to be fixed.
Version 1.1.6
Build: 1666711419
The text was updated successfully, but these errors were encountered: