minimum_error_simplification bug

[lyudalev]

Fred/include/simplification.hpp

Line 113 in 98b8f5a

predecessor = predecessors[predecessor][--ell];

The referenced line should be executed one time less. On the last iteration of the loop 'ell' becomes -1, which is a bug. As a workaround this line can be prefixed with something like 'if (i < l - 1)' or 'if (ell)' like below:

        curve_size_t ell = l;
        
        result.push_back(curve.back());
        curve_size_t predecessor = predecessors[curve.complexity() - 1][--ell];
        
        for (curve_size_t i = 0; i  < l; ++i) {
            result.push_back(curve[predecessor]);
            if (i < l - 1)  // or if (ell)
                predecessor = predecessors[predecessor][--ell];
        }

[derohde]

Hi,

thanks for noticing! This is a really small bug, nevertheless I fixed it and issued a new version.