Merge pull request doctrine#5777 from morozov/irrelevant-throws-annot…

…ations Remove irrelevant @throws annotations
derrabus · Oct 19, 2022 · 2e5aa74 · 2e5aa74
2 parents 88cfa33 + 639c058
commit 2e5aa74
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 40 deletions.
diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php
@@ -339,8 +339,6 @@ public function registerDoctrineTypeMapping(string $dbType, string $doctrineType
 
     /**
      * Gets the Doctrine type that is mapped for the given database column type.
-     *
-     * @throws Exception
      */
     public function getDoctrineTypeMapping(string $dbType): string
     {
@@ -835,8 +833,6 @@ public function getDropUniqueConstraintSQL(string $name, string $tableName): str
      * on this platform.
      *
      * @return list<string> The list of SQL statements.
-     *
-     * @throws Exception
      */
     public function getCreateTableSQL(Table $table): array
     {
@@ -847,19 +843,13 @@ public function getCreateTableSQL(Table $table): array
      * @internal
      *
      * @return list<string>
-     *
-     * @throws Exception
      */
     final protected function getCreateTableWithoutForeignKeysSQL(Table $table): array
     {
         return $this->buildCreateTableSQL($table, false);
     }
 
-    /**
-     * @return list<string>
-     *
-     * @throws Exception
-     */
+    /** @return list<string> */
     private function buildCreateTableSQL(Table $table, bool $createForeignKeys): array
     {
         if (count($table->getColumns()) === 0) {
@@ -958,8 +948,6 @@ private function buildCreateTableSQL(Table $table, bool $createForeignKeys): arr
      * @param list<Table> $tables
      *
      * @return list<string>
-     *
-     * @throws Exception
      */
     public function getCreateTablesSQL(array $tables): array
     {
@@ -1102,8 +1090,6 @@ public function getCreateTemporaryTableSnippetSQL(): string
      * Generates SQL statements that can be used to apply the diff.
      *
      * @return list<string>
-     *
-     * @throws Exception
      */
     public function getAlterSchemaSQL(SchemaDiff $diff): array
     {
@@ -1560,8 +1546,6 @@ public function getColumnDeclarationListSQL(array $columns): string
      *          a string that defines the complete column
      *
      * @return string DBMS specific SQL code portion that should be used to declare the column.
-     *
-     * @throws Exception
      */
     public function getColumnDeclarationSQL(string $name, array $column): string
     {
@@ -2233,8 +2217,6 @@ public function getTimeFormatString(): string
 
     /**
      * Adds an driver-specific LIMIT clause to the query.
-     *
-     * @throws Exception
      */
     final public function modifyLimitQuery(string $query, ?int $limit, int $offset = 0): string
     {
@@ -2401,8 +2383,6 @@ protected function getLikeWildcardCharacters(): string
 
     /**
      * Compares the definitions of the given columns in the context of this platform.
-     *
-     * @throws Exception
      */
     public function columnsEqual(Column $column1, Column $column2): bool
     {

diff --git a/src/Platforms/Exception/NoColumnsSpecifiedForTable.php b/src/Platforms/Exception/NoColumnsSpecifiedForTable.php
@@ -4,12 +4,12 @@
 
 namespace Doctrine\DBAL\Platforms\Exception;
 
-use Exception;
+use LogicException;
 
 use function sprintf;
 
 /** @psalm-immutable */
-final class NoColumnsSpecifiedForTable extends Exception implements PlatformException
+final class NoColumnsSpecifiedForTable extends LogicException implements PlatformException
 {
     public static function new(string $tableName): self
     {

diff --git a/src/SQL/Builder/CreateSchemaObjectsSQLBuilder.php b/src/SQL/Builder/CreateSchemaObjectsSQLBuilder.php
@@ -4,7 +4,6 @@
 
 namespace Doctrine\DBAL\SQL\Builder;
 
-use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\Schema;
 use Doctrine\DBAL\Schema\Sequence;
@@ -18,11 +17,7 @@ public function __construct(private readonly AbstractPlatform $platform)
     {
     }
 
-    /**
-     * @return list<string>
-     *
-     * @throws Exception
-     */
+    /** @return list<string> */
     public function buildSQL(Schema $schema): array
     {
         return array_merge(
@@ -54,8 +49,6 @@ private function buildNamespaceStatements(array $namespaces): array
      * @param list<Table> $tables
      *
      * @return list<string>
-     *
-     * @throws Exception
      */
     private function buildTableStatements(array $tables): array
     {

diff --git a/src/Schema/Comparator.php b/src/Schema/Comparator.php
@@ -4,7 +4,6 @@
 
 namespace Doctrine\DBAL\Schema;
 
-use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
 use function array_map;
@@ -24,8 +23,6 @@ public function __construct(private readonly AbstractPlatform $platform)
 
     /**
      * Returns the differences between the schemas.
-     *
-     * @throws Exception
      */
     public function compareSchemas(Schema $oldSchema, Schema $newSchema): SchemaDiff
     {
@@ -143,8 +140,6 @@ public function diffSequence(Sequence $sequence1, Sequence $sequence2): bool
 
     /**
      * Compares the tables and returns the difference between them.
-     *
-     * @throws Exception
      */
     public function compareTables(Table $oldTable, Table $newTable): TableDiff
     {
@@ -280,8 +275,6 @@ public function compareTables(Table $oldTable, Table $newTable): TableDiff
      * @param array<string,Column> $removedColumns
      *
      * @return array<string,Column>
-     *
-     * @throws Exception
      */
     private function detectRenamedColumns(array &$addedColumns, array &$removedColumns): array
     {
@@ -405,8 +398,6 @@ protected function diffForeignKey(ForeignKeyConstraint $key1, ForeignKeyConstrai
 
     /**
      * Compares the definitions of the given columns
-     *
-     * @throws Exception
      */
     protected function columnsEqual(Column $column1, Column $column2): bool
     {