Remove irrelevant @throws annotations #5777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of its introduction in #4746,
Comparator::columnsEqual()
was annotated with@throws Exception
because the following code flow could result in one:Comparator::columnsEqual()
→AbstractPlatform::columnsEqual()
→AbstractPlatform::getColumnDeclarationSQL()
→AbstractPlatform::getInlineColumnCommentSQL()
. The last method in the chain would throw an exception if the platform didn't support inline column comments.As of #5727, the
NotSupported
exception is declared as unchecked (extendsLogicException
), so this code path no longer throws a checked exception. In fact, this makes the Comparator API free of checked exceptions.Additionally, declaring
NoColumnsSpecifiedForTable
as unchecked allows removing most of the@throws
annotations from the Platform API. The remaining @throws is related to the type registry and is out of the scope of this change.Note that the recent versions of PHPStan support analyzing the
@throws
(see Bring your exceptions under control with @throws). We may want to use them on CI in the future.