Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation doc #52

Closed
wants to merge 1 commit into from
Closed

Conversation

sroucheray
Copy link

I guess there was a misleading copy&paste in the animation documentation

@desandro
Copy link
Member

Both 'css' and 'none' are valid strings that will trigger Isotope to use css(). See lines 380-381. Were you having issues setting animationEngine to 'css' ?

@sroucheray
Copy link
Author

Ok, I have seen this but I thought it was a bit confusing in the doc given this part title is None, its value css and the previous part is Only CSS transitions and its value is css as well.
I found this when I had trouble disabling animation only when items are added (along with infinite scroll). I thought I could use this kind of code in the infinite scroll callback :

//disable animations when inserting new item
$.fx.off = true;
$content.isotope( "option", {"animationEngine" : "jquery"});
$content.isotope( 'insert', $( newElements ) ); 
//re-enable animations when done
$.fx.off = false;
$content.isotope( "option", {"animationEngine" : "best-available"});

But it seems it does not work, I think it comes from that applyStyleFnName is not updated when you change the animationEngine after initialization, is it ?

@desandro
Copy link
Member

Yes, changing animationEngine has no effect after initialization. I've opened issue #53. A setter would needed to be implemented so that the other properties related to animationEngine would also be updated.

@desandro desandro closed this May 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants