New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with v3.3.2 #1

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
2 participants
@ocean90
Contributor

ocean90 commented Aug 15, 2016

Masonry.prototype.options is no longer defined, this.options is and does the same.

See https://core.trac.wordpress.org/ticket/37666.

Improve compatibility with v3.3.2
`Masonry.prototype.options` is no longer defined, `this.options` is and does the same.

See https://core.trac.wordpress.org/ticket/37666.

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 15, 2016

External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261


git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd

aaronjorbin added a commit to aaronjorbin/develop.wordpress that referenced this pull request Aug 15, 2016

External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.


git-svn-id: https://develop.svn.wordpress.org/branches/4.6@38262 602fd350-edb4-49c9-b593-d223f7449a82

markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 15, 2016

External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262


git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@desandro

This comment has been minimized.

Show comment
Hide comment
@desandro

desandro Aug 15, 2016

Owner

Sounds good!

Owner

desandro commented Aug 15, 2016

Sounds good!

@desandro desandro merged commit f5e9aac into desandro:master Aug 15, 2016

@ocean90 ocean90 deleted the ocean90:patch-1 branch Aug 15, 2016

chutzimir pushed a commit to chutzimir/wordpress that referenced this pull request Aug 15, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262


git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd

chutzimir pushed a commit to chutzimir/wordpress that referenced this pull request Aug 15, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261


git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd

svn2github pushed a commit to svn2github/wp-svn-2-git that referenced this pull request Aug 16, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261


git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd

dustinrue pushed a commit to openfcci/wordpress that referenced this pull request Aug 16, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261


git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd

dustinrue pushed a commit to openfcci/wordpress that referenced this pull request Aug 17, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262


git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd

staylor pushed a commit to staylor/develop.svn.wordpress.org that referenced this pull request Aug 18, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.



git-svn-id: https://develop.svn.wordpress.org@38261 602fd350-edb4-49c9-b593-d223f7449a82

staylor pushed a commit to staylor/develop.svn.wordpress.org that referenced this pull request Aug 18, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.


git-svn-id: https://develop.svn.wordpress.org@38262 602fd350-edb4-49c9-b593-d223f7449a82

rockblock pushed a commit to rockblock/wordpress-4-6-1 that referenced this pull request Sep 9, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261

rockblock pushed a commit to rockblock/wordpress-4-6-1 that referenced this pull request Sep 9, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262

wgordon17 pushed a commit to wgordon17/openshift-wordpress that referenced this pull request Nov 10, 2016

External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262


git-svn-id: https://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd

opnsec pushed a commit to opnsec/test that referenced this pull request Nov 20, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.


Built from https://develop.svn.wordpress.org/trunk@38261

opnsec pushed a commit to opnsec/test that referenced this pull request Nov 20, 2016

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262

nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Feb 16, 2017

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
See #37666, #32802.



git-svn-id: https://develop.svn.wordpress.org/trunk@38261 602fd350-edb4-49c9-b593-d223f7449a82

kierzniak pushed a commit to friendsofwp/wordpress that referenced this pull request Jul 11, 2017

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262

fcc-machine-user pushed a commit to openfcci/wordpress that referenced this pull request Sep 22, 2017

jorbin
External Libraries: Update Masonry shim to prevent error using isAnim…
…ated option

Merges [38261] to the 4.6 branch.

The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891].

Reported upstream: desandro/masonry-v2-3-shim#1

Props stephenharris, ocean90, azaozz for testing and second sign off.
Fixes #37666.
See #32802.

Built from https://develop.svn.wordpress.org/branches/4.6@38262


git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment