New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve compatibility with v3.3.2 #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Masonry.prototype.options` is no longer defined, `this.options` is and does the same. See https://core.trac.wordpress.org/ticket/37666.
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 15, 2016
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. Built from https://develop.svn.wordpress.org/trunk@38261 git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
aaronjorbin
added a commit
to aaronjorbin/develop.wordpress
that referenced
this pull request
Aug 15, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. git-svn-id: https://develop.svn.wordpress.org/branches/4.6@38262 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 15, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262 git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sounds good! |
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Aug 16, 2016
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. Built from https://develop.svn.wordpress.org/trunk@38261 git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dustinrue
pushed a commit
to openfcci/wordpress
that referenced
this pull request
Aug 16, 2016
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. Built from https://develop.svn.wordpress.org/trunk@38261 git-svn-id: http://core.svn.wordpress.org/trunk@38202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
dustinrue
pushed a commit
to openfcci/wordpress
that referenced
this pull request
Aug 17, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262 git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
staylor
pushed a commit
to staylor/develop.svn.wordpress.org
that referenced
this pull request
Aug 18, 2016
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. git-svn-id: https://develop.svn.wordpress.org@38261 602fd350-edb4-49c9-b593-d223f7449a82
staylor
pushed a commit
to staylor/develop.svn.wordpress.org
that referenced
this pull request
Aug 18, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. git-svn-id: https://develop.svn.wordpress.org@38262 602fd350-edb4-49c9-b593-d223f7449a82
rockblock
pushed a commit
to rockblock/wordpress-4-6-1
that referenced
this pull request
Sep 9, 2016
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. Built from https://develop.svn.wordpress.org/trunk@38261
rockblock
pushed a commit
to rockblock/wordpress-4-6-1
that referenced
this pull request
Sep 9, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262
wgordon17
pushed a commit
to wgordon17/openshift-wordpress
that referenced
this pull request
Nov 10, 2016
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262 git-svn-id: https://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Feb 16, 2017
…ated option The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. See #37666, #32802. git-svn-id: https://develop.svn.wordpress.org/trunk@38261 602fd350-edb4-49c9-b593-d223f7449a82
kierzniak
pushed a commit
to friendsofwp/wordpress
that referenced
this pull request
Jul 11, 2017
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262
fcc-machine-user
pushed a commit
to openfcci/wordpress
that referenced
this pull request
Sep 22, 2017
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262 git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
VenusPR
added a commit
to VenusPR/Wordpress_Richard
that referenced
this pull request
Mar 9, 2023
…ated option Merges [38261] to the 4.6 branch. The isAnimated option throws an error and causes Masonry to stop functioning. Masonry.prototype.options is no longer defined in 3.3.2, this.options is and does the same. Masonry was updated to 3.3.2 in [37891]. Reported upstream: desandro/masonry-v2-3-shim#1 Props stephenharris, ocean90, azaozz for testing and second sign off. Fixes #37666. See #32802. Built from https://develop.svn.wordpress.org/branches/4.6@38262 git-svn-id: http://core.svn.wordpress.org/branches/4.6@38203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masonry.prototype.options
is no longer defined,this.options
is and does the same.See https://core.trac.wordpress.org/ticket/37666.