Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with background-image css property? #19

Closed
brpsmith opened this issue Nov 23, 2016 · 3 comments
Closed

Issue with background-image css property? #19

brpsmith opened this issue Nov 23, 2016 · 3 comments
Assignees
Labels

Comments

@brpsmith
Copy link

brpsmith commented Nov 23, 2016

Hello - Thank you for creating this solution. It is very helpful. One thing I noticed is that the URL for the background-image property does not properly convert. For example the following HTML:

<td style="background-position:center; background-position:top; background-image: url('https://s3.amazonaws.com/preferably-dev/templates/images/bg_desktop.png');">
converts to:

<td style="background-position:center; background-position:top; background-image: url('https');">

Do you know if this is expected/part of react validation or some other dependency?

Thanks.

Brian

@Deschtex
Copy link
Owner

Deschtex commented Nov 23, 2016

Hey @brpsmith, I'm glad that you find it helpful!

The issue described is caused by a naive split when separating the key from the value in e.g. background-image: url(https://...).

The fix will be based on v1.0.0, which I released earlier today. It (unfortunately) expects react@^15.4.0 and react-dom@^15.4.0 as peer dependencies.

If that's a problem for you I'll need to add the fix on top of v0.3.5 as well.

Thanks for reporting it! I'll notify you when it's fixed.

@Deschtex
Copy link
Owner

@brpsmith I just published v1.0.1. Could you please verify it fixes the issue?

@Deschtex Deschtex self-assigned this Nov 23, 2016
@Deschtex Deschtex added the bug label Nov 23, 2016
@brpsmith
Copy link
Author

Thanks @Deschtex! It works perfectly. Sincerely appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants