Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(part 6.2.2): fix overflow-x caused by a non responsive image #151

Merged
merged 2 commits into from Jul 6, 2022

Conversation

lauthieb
Copy link
Contributor

@lauthieb lauthieb commented Jul 1, 2022

Hello,

First of all, a huge thank you to all the people who have contributed so far to this wonderful initiative.
Being passionate about UI and standardization, I loved reading the second draft and I want to be part of the contributors by proposing some changes that I hope you will like.

In this PR, I propose you to fix a UI bug in the format module documentation.

Bug description

Because of the image in part 6.2.2 "GUI Tools" was declared in Markdown format, it generated an image with a fixed width of 426px. Setting a width: 100% and max-width: 426px solves this problem for mobile screens.

Before

CleanShot 2022-07-01 at 02 06 19@2x

After

CleanShot 2022-07-01 at 02 05 58@2x

Please, don't hesitate if you have any remarks.

Thanks in advance for your review!

@netlify
Copy link

netlify bot commented Jul 1, 2022

Deploy Preview for dtcg-tr ready!

Name Link
🔨 Latest commit b9aaa98
🔍 Latest deploy log https://app.netlify.com/sites/dtcg-tr/deploys/62c4dde628d0ad000971db0c
😎 Deploy Preview https://deploy-preview-151--dtcg-tr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kaelig
Copy link
Member

kaelig commented Jul 6, 2022

Merci Laurent ! After looking into it, I found there are styles available for images to adapt correctly to viewport sizes, as seen in https://respec.org/docs/#figures-table-of-figure, so I went ahead and updated the PR to use that method in b9aaa98 (#151)

@kaelig kaelig merged commit f3606c3 into design-tokens:main Jul 6, 2022
github-actions bot added a commit that referenced this pull request Jul 6, 2022
…#151)

SHA: f3606c3
Reason: push, by @kaelig

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2022
…#151)

SHA: f3606c3
Reason: push, by @kaelig

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 6, 2022
…#151)

SHA: f3606c3
Reason: push, by @kaelig

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lauthieb
Copy link
Contributor Author

lauthieb commented Jul 6, 2022

Hi @kaelig, de rien ! :)
Oh yes, you're right, thanks for this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants