Fix the color alpha syntax to be 50% #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
c1rrus
approved these changes
Nov 17, 2022
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2022
SHA: 6c0a7c6 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2022
SHA: 6c0a7c6 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2022
SHA: 6c0a7c6 Reason: push, by kaelig Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed an issue with the Example 15 and https://design-tokens.github.io/community-group/format/#example-16: Per the spec text, the 24 bit color value is expected to be transformed into a color with the alpha value of
50%, while88would be actually around53%, being a common misconception when writing the component in 8bit format.This PR changes any mentioned
#00000088colors to#00000080to match the intent and fix the examples.