Prettier pre-commit hook #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for dtcg-tr ready! 🔨 Explore the source changes: e4936a9 🔍 Inspect the deploy log: https://app.netlify.com/sites/dtcg-tr/deploys/6139125d774f170008a821cf 😎 Browse the preview: https://deploy-preview-57--dtcg-tr.netlify.app |
|
Useful for folks who don't have the prettier extension installed in VS Code! |
kaelig
reviewed
Sep 9, 2021
| "editor.formatOnSave": true, | ||
| "editor.formatOnPaste": true | ||
| "editor.formatOnPaste": true, | ||
| "files.insertFinalNewline": true |
There was a problem hiding this comment.
This should be taken care of by editorconfig (which I forgot to add to the list of recommended extensions, sorry!)?
There was a problem hiding this comment.
(I added editorconfig to the list of recommended extensions, do we still need this?)
This was referenced Sep 13, 2021
Merged
|
Closing this in favor of #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed that a pull request was failing a linting check, but not telling me why it was failing. Instead, what repositories generally do is have a pre-commit hook that runs prettier on files that were changed in the commit and writes the prettier changes. This way the contributor won't have to remember to run prettier and fix the issue by hand. Open to suggestions though!