Cache buster failure fallback

[julianlam]

Currently, cache buster is enabled on non development runs of NodeBB. This cache buster string is generated by running git describe --tags on the system. However, on some systems (Mac OS X), this command errors out with a fatal: No names found, cannot describe anything..

If this happens, we proceed without a cache buster, but we should fallback instead.

If git describe --tags fails for whatever reason (for example, I believe @akhoury's environment does not use git?), we should fall back to a different method of cache buster generation.

My suggestion is to have ./nodebb upgrade touch package.json. Therefore, we can read its' last modified date, and use that timestamp as a cache buster.

[akhoury]

neato ! i like the touch package.json idea

[psychobunny]

nice touch.
On 2014-02-11 6:31 PM, "Aziz Khoury" notifications@github.com wrote:

neato ! i like the touch package.json idea

Reply to this email directly or view it on GitHubhttps://github.com//issues/1006#issuecomment-34821872
.

[julianlam]

#iseewhatyoudidthere

[akhoury]

thanks