Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script overrides some meta configs #275

Closed
julianlam opened this issue Sep 10, 2013 · 0 comments
Closed

Installation script overrides some meta configs #275

julianlam opened this issue Sep 10, 2013 · 0 comments
Assignees
Labels
Milestone

Comments

@julianlam
Copy link
Member

Some meta configs (such as postDelay) are now set in install.js, but they are always set irregardless of whether or not they have been set before.

Best possible solution would be a new method in Meta called setOnEmpty, which would call set if the config itself returns (nil), otherwise continues.

While we're at it, it looks like the meta config sets could be parallelised using async.

@ghost ghost assigned julianlam Sep 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant