i18n for all templates and, json-Files for german language added #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, looks like you put in a lot of work into this, thanks! I'll have @psychobunny take a look at this if he's free. I do know that someone from NodeCode.de came by and translated NodeBB into german already, but he never shared the language files to us, so this is great! |
| "browsing": "browsing", | ||
| "no_one_has_replied": "Niemand hat geantwortet", | ||
| "replied": "geantwortet", |
There was a problem hiding this comment.
Some of these are still in German! 😄
|
thanks for this @BudickDa, very very awesome :) |
|
Don't worry @BudickDa, I fixed the issues outlined above before merging in :) |
julianlam
pushed a commit
that referenced
this pull request
Dec 6, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, great work. NodeBB is totally awesome, I found it yesterday and played with it all day. It is great and I will totally use it!
What I did:
I overlooked all templates and replaced Strings with placeholders for i18n.
Then I added the new placeholders into the language json-files and placed the right String there.
After that I translated everything into German and put it into /public/language/de.
Hope it helps.
Greetings from Germany