Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate verbose output from desimodel_data.sh #75

Closed
weaverba137 opened this issue Feb 23, 2018 · 1 comment
Closed

Eliminate verbose output from desimodel_data.sh #75

weaverba137 opened this issue Feb 23, 2018 · 1 comment
Assignees

Comments

@weaverba137
Copy link
Member

The script that fetches the extra data associated with desimodel, etc/desimodel_data.sh, is run with #!/bin/bash -x. The extra debugging output may be interpreted by desiInstall as an error message, and prevent normal installation.

@weaverba137 weaverba137 self-assigned this Feb 23, 2018
@weaverba137
Copy link
Member Author

Additional note. In addition to -x, the script also sets -e, which causes the script to exit on any non-zero return code.

This line:

[[ -z "${DESIMODEL}" ]] && export DESIMODEL=$(pwd)

and specifically [[ -z "${DESIMODEL}" ]] returns 0 during Travis tests, but 1 during desiInstall, because desiInstall has already set $DESIMODEL. In other words, the existence of $DESIMODEL causes the script to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant