Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package dependencies and non-dependencies in desisim #43

Closed
weaverba137 opened this issue Nov 11, 2015 · 8 comments
Closed

Package dependencies and non-dependencies in desisim #43

weaverba137 opened this issue Nov 11, 2015 · 8 comments
Assignees
Labels

Comments

@weaverba137
Copy link
Member

While analyzing the packages that desisim depends on, I found a few anomalies that I need to ask about.

  1. Why doesn't desisim depend on specsim?
  2. Is matplotlib strictly necessary for the functioning of the package?
  3. Why does code in the qso_template section depend on xastropy?
@weaverba137
Copy link
Member Author

PS, the purpose of this question is to determine exactly which packages need to be installed for Travis tests to succeed.

@sbailey
Copy link
Contributor

sbailey commented Nov 11, 2015

Why doesn't desisim depend on specsim?

The parts of desisim that would depend on specsim (quickgen) pre-dated the existence of specsim (though the final merge did not). In the future it will depend on specsim, but we just haven't done the refactor yet.

Is matplotlib strictly necessary for the functioning of the package?

It is needed for the QA plots but not the algorithms. See comment on desispec #94 for skipping tests if matplotlib is a limiting factor for Travis.

Why does code in the qso_template section depend on xastropy?

@profxj was probably being pragmatic in using the tools he had available. He can comment on how easy it would be to clean that up when merging qso_template.

@weaverba137
Copy link
Member Author

What is the schedule for merging qso_template into the main desisim package? I'm waiting on that to happen so I can determine the final set of dependencies.

@dkirkby
Copy link
Member

dkirkby commented Nov 13, 2015

Are you waiting on the quicksim -> specsim migration, or can we finalize the current dependencies to close this issue and then update them as part of #44 ?

@weaverba137
Copy link
Member Author

Yes, I'm waiting for the migration. We should have only one package in the py/ directory.

@dkirkby
Copy link
Member

dkirkby commented Nov 13, 2015

The quicksim -> specsim migration is unrelated to merging qso_template into the main desisim package.

@weaverba137
Copy link
Member Author

Sorry, by 'migration', I specifically meant the merge of qso_template.

@sbailey
Copy link
Contributor

sbailey commented Feb 25, 2016

qso_template has been merged into desisim/ (PR #67) and the quicksim -> specsim migration is complete (#57 and #86). Closing ticket.

@sbailey sbailey closed this as completed Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants