Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Publish button in Repository Settings if no commits for a new repo #2086

Closed
tierninho opened this issue Jun 22, 2017 · 1 comment
Closed
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@tierninho
Copy link
Contributor

If you create a new repo and undo the initial commit the Publish button in the main menu is disabled by design, however, you can still access the publish the repo via the Repo Settings modal, which results in an "unborn branch" error.

v0.6.1, OSX 10.11.5

Reproduce:

  • Create new repo (File > New Repo)
  • Undo initial commit (Publish button should disable)
  • Go to Repository > Repo settings
  • Click Publish, try to publish

The Publish button on the repo settings modal should be disabled and/or the text should change to reflect the state.

screen shot 2017-06-22 at 9 08 08 am

screen shot 2017-06-22 at 9 11 03 am

@tierninho tierninho added the bug Confirmed bugs or reports that are very likely to be bugs label Jun 22, 2017
@joshaber joshaber changed the title Disable Publish button if no commits for a new repo Disable Publish button in Repository Settings if no commits for a new repo Jun 22, 2017
@shiftkey
Copy link
Member

If you create a new repo and undo the initial commit the Publish button in the main menu is disabled by design, however, you can still access the publish the repo via the Repo Settings modal, which results in an "unborn branch" error.

This makes me think we're going about it the wrong way - we should let the user publish always, and detect when the repository is unborn and skip the attempt to push the branch. There may need to be some UX thoughts about this to distinguish between publish and push, but maybe we just need to make "push" clear that it has nothing to push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

2 participants