Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support seems to have regressed #498

Open
itsananderson opened this issue Sep 17, 2022 · 4 comments · May be fixed by #539
Open

Proxy support seems to have regressed #498

itsananderson opened this issue Sep 17, 2022 · 4 comments · May be fixed by #539

Comments

@itsananderson
Copy link

There's an old closed issue #148 where someone reported problems installing dugite behind a proxy. The recommended solution was to set HTTP_PROXY/HTTPS_PROXY which is also documented in the environment variable docs. It seems, however, that when dugite migrated away from requests, those environment variables stopped having any effect.

Now that dugite is using the raw https module, it looks like the easiest solution might be to add global-agent as a dependency and use it inside download-git.js. Here's how @electron/get uses global-agent, for example.

If that solution makes sense (or if you can suggest another solution you'd prefer), I'd be happy to submit a PR.

@richardo2016
Copy link
Contributor

It make sense, I'd like to see a PR to add global-agent : )

@tpeplinx
Copy link

Hi, that would be great, because in my case it is blocking Electron update.

@itsananderson itsananderson linked a pull request Apr 11, 2023 that will close this issue
@jasonqsong
Copy link

For whom ran into this issue,

cd /tmp && wget https://github.com/desktop/dugite-native/releases/download/v2.39.1/dugite-native-v2.39.1-6e9b509-ubuntu.tar.gz

should help the post install script to use the downloaded cache

@panther7
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants