You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allows the minter to mint a POAP token to a recipient in the event period if the contract enables mint. This message has the following parameter:
In the code, MintTo calls the execute_mint() function, passing the check_authorized_to_mint parameter as true. Therefore, it performs the following check:
// Check if who is performing the action is the minter
if check_authorized_to_mint && info.sender != config.minter && info.sender != config.admin{
returnErr(ContractError::Unauthorized{});
}
Thus, both the admin and the minter can mint a token, contradicting the README, which states that "the minter can mint a POAP token if the contract enables mint". Moreover, the minter and the admin are able to mint the token even if the "mint is not enabled".
The README should correctly reflect the code's functionality. In this case, it should clarify that both the admin and the minter are able to mint a token and that they bypass the mint_enabled check.
The text was updated successfully, but these errors were encountered:
Feature description
It seems there might be a discrepancy in the poap contract README specifically in the description of the MintTo function
desmos-contracts/contracts/poap/README.md
Lines 76 to 77 in 946688e
execute_mint()
function, passing thecheck_authorized_to_mint
parameter astrue
. Therefore, it performs the following check:desmos-contracts/contracts/poap/src/contract.rs
Lines 216 to 219 in 946688e
Thus, both the admin and the minter can mint a token, contradicting the README, which states that "the minter can mint a POAP token if the contract enables mint". Moreover, the
minter
and theadmin
are able to mint the token even if the "mint is not enabled".desmos-contracts/contracts/poap/src/contract.rs
Lines 211 to 214 in 946688e
Implementation proposal
The README should correctly reflect the code's functionality. In this case, it should clarify that both the admin and the minter are able to mint a token and that they bypass the
mint_enabled
check.The text was updated successfully, but these errors were encountered: