Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POAP: Potential Misnaming of the 'MINTER_ADDRESS' State Variable #189

Closed
giorgionocera opened this issue Jul 11, 2023 · 0 comments · Fixed by #195
Closed

POAP: Potential Misnaming of the 'MINTER_ADDRESS' State Variable #189

giorgionocera opened this issue Jul 11, 2023 · 0 comments · Fixed by #195
Labels
new-feature Propose the addition of a new feature that does not yet exist

Comments

@giorgionocera
Copy link

Feature description

The state variable MINTER_ADDRESS is currently used to store data related to the tokens (POAPs) minted to different wallets (addresses). Here, the address serves as the key, and the value represents the number of POAPs minted to that address

pub const MINTER_ADDRESS: Map<Addr, u32> = Map::new("minter_address");
Given its usage, the name "MINTER_ADDRESS" might not accurately reflect the data it holds.

Implementation proposal

Considering the data held by this state variable, a more descriptive name could be MINTED_TOKENS. This change would make the purpose of this variable clearer to developers who read the code, improving the readability and understandability of the codebase.

@giorgionocera giorgionocera added the new-feature Propose the addition of a new feature that does not yet exist label Jul 11, 2023
@RiccardoM RiccardoM mentioned this issue Jul 17, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Propose the addition of a new feature that does not yet exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant