Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adaptive icon #607

Closed
2 of 3 tasks
Commenter25 opened this issue Jan 5, 2024 · 3 comments · Fixed by #672
Closed
2 of 3 tasks

Add adaptive icon #607

Commenter25 opened this issue Jan 5, 2024 · 3 comments · Fixed by #672
Labels
enhancement New feature or request

Comments

@Commenter25
Copy link

  • Did you check to see if this issue already exists?
  • Is this only a single feature request? Do not put multiple feature requests in one issue.
  • Is this a question or discussion? Don't use this, use https://lemmy.ml/c/thumbkey

Describe the feature request below
Most apps use an icon marked with a safe zone that can be cropped to different shapes for different styles. Thumb-Key does not do this, which makes it inconsistent with the rest of the system. Fixing this is a minor thing, but a major aesthetic improvement. https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

I've attached multiple images to showcase the issue, next to icons which have properly adaptive icons.

To start, the worst case scenario, the icon displayed raw on a pure black background. It doesn't exist.
The app on a black background

In a more common scenario of a colorful background, this isn't as big of an issue. However, it is still an obvious standout from the rest of the system, especially with the odd spacing making it higher up rather than centered.
The app on a teal background

Depending on the launcher, it may try to force it into being a pseudo-adaptive icon. This fixes readability issues, but the spacing issues become even more apparent as it tries to avoid cropping the image and adds a lot of additional padding.
The app on a black background, with a pseudo-adaptive icon
The app on a teal background, with a pseudo-adaptive icon

@Commenter25 Commenter25 added the enhancement New feature or request label Jan 5, 2024
@dessalines
Copy link
Owner

That'd be much appreciated if someone who knows how to do this could handle it.

@KraXen72
Copy link
Contributor

@KraXen72
Copy link
Contributor

I think the icon itself could use a redrawing as it currently doesen't look that great imo. if i have some idea for a better icon i'll try to whip up some svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants