Add left handed EN messagease #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested changes
Feb 8, 2024
app/src/main/java/com/dessalines/thumbkey/keyboards/CommonKeys.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dessalines/thumbkey/utils/KeyboardLayout.kt
Outdated
Show resolved
Hide resolved
BlueDrink9
force-pushed
the
messageease_left
branch
3 times, most recently
from
e4dbb54
to
8a2b194
Compare
|
See #661 (comment) So it'd probably be best to leave the function, but add a setting. |
|
Also don't stack PRs please. If one builds on another, mark that one as draft until your first PR is merged. |
|
The UI change to add the setting and translations etc is a bit beyond me at the moment, will need to wait until I have more time. I'll open a draft PR for it, and let this one get merged as separate layouts for now |
added 9 commits
February 12, 2024 20:50
BlueDrink9
force-pushed
the
messageease_left
branch
from
c8b1b5c
to
25a3420
Compare
|
ci failed due to network error |
dessalines
approved these changes
Feb 12, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally refactors out the ABC button as a common key; let me know if you'd rather I undo that or extend it to shift, BS and return
Partially addresses #661