-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add left handed EN messagease #696
Conversation
app/src/main/java/com/dessalines/thumbkey/keyboards/CommonKeys.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dessalines/thumbkey/utils/KeyboardLayout.kt
Outdated
Show resolved
Hide resolved
e4dbb54
to
8a2b194
Compare
See #661 (comment) So it'd probably be best to leave the function, but add a setting. |
Also don't stack PRs please. If one builds on another, mark that one as draft until your first PR is merged. |
The UI change to add the setting and translations etc is a bit beyond me at the moment, will need to wait until I have more time. I'll open a draft PR for it, and let this one get merged as separate layouts for now |
c8b1b5c
to
25a3420
Compare
ci failed due to network error |
Additionally refactors out the ABC button as a common key; let me know if you'd rather I undo that or extend it to shift, BS and return
Partially addresses #661