Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for English MessagEase keyboard #719

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

mpsijm
Copy link
Contributor

@mpsijm mpsijm commented Feb 12, 2024

I've included @JDeeth's commit from #687 (making that PR obsolete) and updated it with the changes that have been made in the past few days. Many of his changes, like adding the numeric keyboard, have already been implemented by others, so the only things remaining from his commit are:

  • Add : key on the bottom-right swipe of the shifted E key in the Symbols keyboard
  • Add (tab) key on the bottom-right swipe of the t key in the Numeric and Symbols keyboards

Additionally:

  • I've made sure that ENMessagEaseNumeric uses the ABC_KEY_ITEM (which also happened in Add left handed EN messagease #696, this is the only keyboard layout that still used the manual key item).
  • On ENMessagEaseNumeric, I've moved < from the bottom-left swipe of the 7 key to the left swipe of the 7 key.

@JDeeth
Copy link
Contributor

JDeeth commented Feb 12, 2024

Excellent, thanks!

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx!

@dessalines dessalines merged commit 4e7a896 into dessalines:main Feb 12, 2024
1 check passed
@mpsijm mpsijm deleted the messagease branch February 13, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants