CommonKeys.kt: Show swipes on NUMERIC_KEY_ITEM also on ABC_KEY_ITEM #720
Conversation
README.md
Outdated
| @@ -69,9 +69,9 @@ This project is a follow-up to the now unmaintained (and closed-source) [Message | |||
| - **Swipe left** to cycle between selected layouts (languages). | |||
| - **Swipe to bottom-left** to toggle voice input. Requires [FUTO Voice Input](https://play.google.com/store/apps/details?id=org.futo.voiceinput). | |||
|
|
|||
| ### Symbol (`#`) Key | |||
| ### Symbol/Letters (`#`/`ABC`) Key | |||
There was a problem hiding this comment.
Seems a bit too verbose now, lets just make this :
### Symbols / Letters Key
README.md
Outdated
|
|
||
| - **Tap** to access numbers & symbols | ||
| - **Tap** to access numbers & symbols - **Tap again** to return to letters |
There was a problem hiding this comment.
Make this two sentences instead of the -
so symbols. Tap again ...
| @@ -32,6 +32,46 @@ import com.dessalines.thumbkey.utils.SlideType | |||
| import com.dessalines.thumbkey.utils.SwipeDirection | |||
| import com.dessalines.thumbkey.utils.SwipeNWay | |||
|
|
|||
| val abcOrNumericSwipes = | |||
There was a problem hiding this comment.
Name this uppercase like the other (pseudo) constants, so val ABC_OR_NUMERIC_SWIPES
There was a problem hiding this comment.
Fixed! I had initially picked the camelCase name because my intention was that this constant would only be used locally (inside CommonKeys.kt), and not in other files. I guess it was a habit from Go to turn it into a constant starting with a lower-case letter, in that case 😛 Kotlin has no way to make a val file-private, right? So I guess that vals are always package-private?
EDIT: should've just googled, of course private val is a thing 😄 Then it's up to you to decide whether this val should be file-private, or that it's fine to let it be package-private 🙂
There was a problem hiding this comment.
Its no probs. Ideally we could use const val UPPERCASE_CONST but that isn't possible for anything but primitive types iirc.
mpsijm
force-pushed
the
swipes-on-abc-key
branch
from
1e13660
to
bc2a1df
Compare
I've extracted the swipes on the Symbol (
#) Key to also show them on the Letters (ABC) Key. Great thanks to the fact that the commonABC_KEY_ITEMis in use for all keyboards now, since #696 and #719 😄