Skip to content
This repository has been archived by the owner on Apr 5, 2021. It is now read-only.

Absurd mutes for repeated text #1

Closed
vaindil opened this issue May 19, 2017 · 6 comments
Closed

Absurd mutes for repeated text #1

vaindil opened this issue May 19, 2017 · 6 comments

Comments

@vaindil
Copy link

vaindil commented May 19, 2017

The bot is giving absurdly long mutes for very little repeated text.

[2017-05-19 00:51:54 UTC] Bot_v2_Beta: 7m ILiedAboutCake: 19% = past text
[2017-05-19 00:52:23 UTC] Bot_v2_Beta: 5m darius_irl: 22% = past text
[2017-05-19 00:52:32 UTC] Bot_v2_Beta: 4m Leawansy: 19% = past text
[2017-05-19 00:53:33 UTC] Bot_v2_Beta: 3m CrazySyd: 19% = past text
[2017-05-19 00:53:40 UTC] Bot_v2_Beta: 7m TekJansen: 24% = past text
[2017-05-19 00:54:09 UTC] Bot_v2_Beta: 6m Spaced03: 27% = past text
[2017-05-19 03:06:37 UTC] Bot_v2_Beta: 8m xtphty: 18% = past text
[2017-05-19 04:03:30 UTC] Bot_v2_Beta: 42m Dranzogger: 31% = past text

@PinkishCow
Copy link

Nom_De_Plume: Rosario Dawson
gachiGASM
Rosario Dawson
DatGeoff
Rosario Dawson
Nom_De_Plume muted by Bot_v2_Beta
Bot_v2_Beta: 2m Nom_De_Plume: 0.608740885039013% = your past text

Maybe the maths is just off somewhere?

@dharmaturtle
Copy link
Contributor

Maths is off, it is using Average of all the similarities instead of the Max. Already fixed, will run the new version... at least when the stream goes live.

@vaindil
Copy link
Author

vaindil commented May 19, 2017

@dharmaturtle Are the mute lengths accurate though? 42 minutes seems pretty extreme.

@dharmaturtle
Copy link
Contributor

Mute lengths are accurate.

He was pasting:

Dranzogger: : >Destiny if you're reading this then I have to say that this was very distasteful. You're saying a wonderful thing though,الله أكبر, which can be interpreted as Allah (God) is the greatest. But since you aren't a Muslim, I assume and therefore aren't saying it sincerely, you can see how you come across surely? Please be respectful of other peoples' religions. It's something that decent human beings should be doing anyways. [I hope i dont get muted for posting muslim speak]

Mute lengths now scale with the length of the spam, where previously they were just 10m. This is due to chat's willingness to accept the mute and paste absurdly long sentences regardless of the mute.

In the future, I may make mutes stack depending on if there were previous occurrences of other other pastes, but that's a feature I'll not have time to implement for at least a week.

If you have a preferred mute length in mind, let me know.

@vaindil
Copy link
Author

vaindil commented May 19, 2017

Gotcha, that makes sense, I suppose I could've looked at the source to find that myself.

My only suggestion would be to drop the length if the matched text is a link. I know Cake's mute was because Destiny asked for a link to something, he posted the link at the exact same time someone else did. 7 minutes seems a bit much for that.

@dharmaturtle
Copy link
Contributor

Meh, why read code when you can avoid it? :]

Links pose an interesting problem. I don't want to drop them entirely, otherwise we'd be vulnerable to stupidly long URLs. However, they do deserve more leniency. A user can post a reddit link, and pasting a permalink to a comment yields a ban. Perhaps only start muting only after it has been posted X times.

Implementation of this feature will occur after mute stacking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@vaindil @dharmaturtle @PinkishCow and others