Run verifyGeneratorOutput in a isolated job #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
force-pushed
the
nc/actions-verify-generator-parallel
branch
from
2559836
to
92c1ef4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2796 +/- ##
=========================================
Coverage 80.51% 80.51%
Complexity 2324 2324
=========================================
Files 386 386
Lines 6955 6955
Branches 1262 1262
=========================================
Hits 5600 5600
Misses 725 725
Partials 630 630 Continue to review full report at Codecov.
|
schalkms
approved these changes
Jun 13, 2020
arturbosch
approved these changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to move the
verifyGeneratorOutputgradle task outside of the Build matrix and run in a parallel job (still within thepre-mergeworkflow).We spend ~1minute in verify the documentation on every build (and this happens 9 times, once for every job of the matrix). We could parallelise this and have a separate job that will just check the generated documentation.
This has also a nice side effect: contributors will see immediately if their build failed because of a test failure or because of missing documentation updates.