Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DetektMultiplatform from unit test to gradle testkit integrati… #3500

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

chao2zhang
Copy link
Member

This is a continuation of #3489. There will be no more unit test depending on Gradle internal API itself.
This also helped catch a potential multi-platform setup issue, therefore I am currently expecting gradle failure in the test.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #3500 (360648b) into master (fce4177) will decrease coverage by 2.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3500      +/-   ##
============================================
- Coverage     79.73%   77.56%   -2.17%     
+ Complexity     2869     2804      -65     
============================================
  Files           461      461              
  Lines          8668     8668              
  Branches       1676     1676              
============================================
- Hits           6911     6723     -188     
- Misses          845     1040     +195     
+ Partials        912      905       -7     
Impacted Files Coverage Δ Complexity Δ
...o/gitlab/arturbosch/detekt/internal/SharedTasks.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../arturbosch/detekt/internal/DetektMultiplatform.kt 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (-3.00%)
...b/arturbosch/detekt/extensions/DetektReportType.kt 0.00% <0.00%> (-83.34%) 0.00% <0.00%> (-2.00%)
...kotlin/io/gitlab/arturbosch/detekt/DetektPlugin.kt 0.00% <0.00%> (-82.23%) 0.00% <0.00%> (-10.00%)
...o/gitlab/arturbosch/detekt/internal/DetektPlain.kt 0.00% <0.00%> (-76.48%) 0.00% <0.00%> (-5.00%)
...itlab/arturbosch/detekt/extensions/DetektReport.kt 0.00% <0.00%> (-75.00%) 0.00% <0.00%> (-3.00%)
...tlab/arturbosch/detekt/DetektCreateBaselineTask.kt 0.00% <0.00%> (-43.48%) 0.00% <0.00%> (-16.00%)
...ab/arturbosch/detekt/extensions/DetektExtension.kt 0.00% <0.00%> (-42.86%) 0.00% <0.00%> (-2.00%)
...tlab/arturbosch/detekt/extensions/DetektReports.kt 0.00% <0.00%> (-35.30%) 0.00% <0.00%> (-5.00%)
.../main/kotlin/io/gitlab/arturbosch/detekt/Detekt.kt 0.00% <0.00%> (-26.27%) 0.00% <0.00%> (-19.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce4177...aee42e0. Read the comment docs.

@cortinico
Copy link
Member

therefore I am currently expecting gradle failure in the test.

There were no failures 🤔

@chao2zhang
Copy link
Member Author

https://github.com/detekt/detekt/pull/3500/files#diff-eecf932f3ad12d79051435e2cd6535e4bfb6bf25c7e82e33fbf7e53c72891c43R148

           // Investigate KMM setup for Android, currently running `check` would result in failure
            // Could not determine the dependencies of task ':shared:detektAndroidDebugAndroidTest

@chao2zhang chao2zhang merged commit da6c969 into detekt:master Feb 27, 2021
@cortinico cortinico added this to the 1.16.0 milestone Mar 3, 2021
@cortinico cortinico added the housekeeping Marker for housekeeping tasks and refactorings label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants