Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deprecated rules when using allRules flag. #6413

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

marschwar
Copy link
Contributor

fixes #6336

This deactivates all deprecated rules when running with the allRules flag to allow warningAsError to be set to true.

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #6413 (f6f42f3) into main (df60c58) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##               main    #6413   +/-   ##
=========================================
  Coverage     85.09%   85.09%           
- Complexity     4006     4010    +4     
=========================================
  Files           567      567           
  Lines         13166    13174    +8     
  Branches       2363     2363           
=========================================
+ Hits          11203    11211    +8     
  Misses          802      802           
  Partials       1161     1161           
Files Changed Coverage Δ
...otlin/io/gitlab/arturbosch/detekt/core/Analyzer.kt 86.79% <80.00%> (+0.51%) ⬆️
...ab/arturbosch/detekt/core/config/AllRulesConfig.kt 82.35% <85.71%> (+5.42%) ⬆️

@marschwar marschwar merged commit 75e88a8 into detekt:main Aug 20, 2023
23 checks passed
@marschwar marschwar deleted the fix/6336_allRules branch August 20, 2023 17:20
@detekt-ci
Copy link
Collaborator

Warnings
⚠️ This PR is approved with no milestone set. If merged, it won't appear in the detekt release notes.

Generated by 🚫 dangerJS against f6f42f3

@cortinico cortinico added this to the 2.0.0 milestone Aug 21, 2023
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
* Disable deprecated rules when using `allRules` flag.

* Remove additional blank line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable OptionalWhenBraces with warningsAsErrors: true
4 participants