Skip to content

Commit

Permalink
chore: handle failure to resolve key->id + adjust testing assert
Browse files Browse the repository at this point in the history
  • Loading branch information
corban-beaird committed May 30, 2024
1 parent 1227c97 commit fdabe47
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion master/internal/project/postgres_project.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ func GetProjectByKey(ctx context.Context, key string) (*model.Project, error) {
Table("projects").
Where("key = ?", key).
Scan(ctx, &projectID)
if err != nil {
if err != nil && errors.Is(err, sql.ErrNoRows) {
return db.ErrNotFound
} else if err != nil {
return err
}

Expand Down
2 changes: 1 addition & 1 deletion master/internal/project/postgres_project_intg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestGetProjectByKey(t *testing.T) {
t.Run("non-existent project key", func(t *testing.T) {
_, err := GetProjectByKey(context.Background(), "bogus")
require.Error(t, err)
require.True(t, strings.Contains(err.Error(), "not found"))
require.ErrorContains(t, err, "not found")
})
}

Expand Down

0 comments on commit fdabe47

Please sign in to comment.