style: correct mobile viewport [DET-4664] #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apizzini
reviewed
Dec 10, 2020
apizzini
approved these changes
Dec 10, 2020
justin-determined-ai
pushed a commit
to justin-determined-ai/determined
that referenced
this pull request
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on different mobile browsers, the viewport height of 100 does not take the browser chrome into calculation. Meaning, when you view the mobile view the bottom of our page will be cut off instead of rendering all of the page to fit nicely in the visible content area.
Detailed explanation of the viewport issue on mobile:
https://css-tricks.com/the-trick-to-viewport-units-on-mobile/
Before:
After:
Test Plan
Test in iOS simulator, both iOS Safari and iOS Chrome.
Test in actual devices once deployed.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.