feat: Deleting workspace/project moves its experiments [DET-7368] #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of [poorly] deleting them
trentwatt
approved these changes
May 20, 2022
mapmeld
added a commit
that referenced
this pull request
May 26, 2022
…4224) * Revert "feat: Deleting workspace/project moves its experiments [DET-7368] (#4191)" This reverts commit 9c575c7. * prevent deleting workspace/proj with experiments; cascade delete of workspace pins * async tree deletion of workspaces, projects, and experiments * add numExperiments to Workspaces API responses, and hide Delete options on WebUI * include update_workspace.sql * Revert "async tree deletion of workspaces, projects, and experiments" This reverts commit bab860c. * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After our discussion about when experiments can/can't be safely deleted and how that process is async / not easy to do en masse, when a project is deleted we're going to move its experiments back to the Uncategorized workspace.
This updates the language in the CLI and WebUI to inform users. Notes on a project get deleted, so I added that in.
Checklist
docs/release-notes/.See Release Note for details.