feat: support arbitrary login redirect routes #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-determined-ai
changed the title
justin-determined-ai
changed the title
hamidzr
added
the
to-cherry-pick
|
This is requested for EE |
hkang1
reviewed
May 18, 2020
webui/react/src/utils/routes.ts
Outdated
|
|
||
| export const parseUrl = (url: string): URL => { | ||
| if (!isFullPath(url)) { | ||
| if (!url.startsWith('/')) url = '/' + url; // TODO assume url is absolute, or we could throw |
There was a problem hiding this comment.
suggestion: could be a useful function
export const isAbsolutePath = (url: string): boolean => url.startsWith('/');
There was a problem hiding this comment.
thoughts about handling relative urls? assume they're absolute or throw
webui/react/src/utils/routes.ts
Outdated
|
|
||
| export const parseUrl = (url: string): URL => { | ||
| if (!isFullPath(url)) { | ||
| if (!url.startsWith('/')) url = '/' + url; // TODO assume url is absolute, or we could throw |
There was a problem hiding this comment.
suggestion: avoid overwriting/mutating function parameters.
For this particular case it's not as significant because it's just a string, but would be good practice for when the objects are complex.
We should add this eslint rule: https://eslint.org/docs/rules/no-param-reassign
There was a problem hiding this comment.
sounds good. and the eslint rule sounds good too and if we need to do that for maybe performance reasons we can ignore it case by case
hamidzr
force-pushed
the
3068-support-arbitrary-redirect
branch
from
1f338b9
to
5980a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DET-3068
Test Plan
Commentary (optional)