Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import defaultAppRoute constant instead of redefining it #523

Merged
merged 1 commit into from May 20, 2020
Merged

chore: import defaultAppRoute constant instead of redefining it #523

merged 1 commit into from May 20, 2020

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented May 14, 2020 •
edited

Description

depends on #522, #551

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label May 14, 2020
@hamidzr hamidzr self-assigned this May 14, 2020
@hamidzr hamidzr marked this pull request as draft May 14, 2020 21:15
@hamidzr hamidzr force-pushed the authtoken-continue branch 3 times, most recently from ff72142 to f9fe9d4 Compare May 19, 2020 16:42
@hamidzr hamidzr marked this pull request as ready for review May 19, 2020 16:52
@hamidzr hamidzr assigned hkang1 and unassigned hamidzr May 19, 2020
@hkang1 hkang1 assigned hamidzr and unassigned hkang1 May 19, 2020
hkang1
hkang1 reviewed May 19, 2020
View reviewed changes
Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a conversation with @hamidzr regarding this. We have a notification approach (modal in the near future) to replace this behavior.

@hamidzr
Copy link
Contributor Author

hamidzr commented May 19, 2020

closing as we are taking a different approach as @hkang1 mentioned.

@hamidzr hamidzr closed this May 19, 2020
@hamidzr hamidzr reopened this May 20, 2020
@hamidzr
Copy link
Contributor Author

hamidzr commented May 20, 2020

didn't realize I have a sorta unrelated commit in here: 5e2f871 get that one in? @hkang1

@hamidzr hamidzr assigned hkang1 and unassigned hamidzr May 20, 2020
@hkang1
Copy link
Contributor

hkang1 commented May 20, 2020

didn't realize I have a sorta unrelated commit in here: 5e2f871 get that one in? @hkang1

yep that one looks good to add

hkang1
hkang1 approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop commit f9fe9d4 and we should be good to go!

@hkang1 hkang1 assigned hamidzr and unassigned hkang1 May 20, 2020
@hamidzr hamidzr changed the title feat: set the next page from AuthToken based on redirect QS chore: import defaultAppRoute constant instead of redefining it May 20, 2020
@hamidzr hamidzr merged commit 5c0e48c into determined-ai:master May 20, 2020
@hamidzr hamidzr deleted the authtoken-continue branch May 20, 2020 19:04
@dannysauer dannysauer added this to the 0.12.5 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkang1 hkang1 hkang1 approved these changes

Assignees

@hamidzr hamidzr

Labels
cla-signed
Projects
None yet
Milestone
0.12.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamidzr @hkang1 @dannysauer