New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add isort to pre-commit #6897

Merged

hamidzr merged 6 commits into main from precommit-isort

May 22, 2023

Contributor

hamidzr commented May 18, 2023 •

edited

Loading

Description

upgrade isort 5.11.5 January 30 2023 [hotfix]
Fixed incompatiblity with latest poetry version
add pre-commit hook for isort
fmt

Test Plan

Commentary (optional)

Checklist

Changes have been manually QA'd
User-facing API changes need the "User-facing API Change" label.
Release notes should be added as a separate file under docs/release-notes/.
See Release Note for details.
Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

hamidzr added 3 commits

May 18, 2023 13:03


          upgrade to isort 5.11.5 and add pre-commit hook

8b317dc

fmt

d699b13


          no need to exclude deepspeed

c775c8d

hamidzr requested review from a team as code owners

May 18, 2023 20:13

hamidzr requested review from salonig23 and removed request for a team

May 18, 2023 20:13

cla-bot bot added the cla-signed label

netlify bot commented May 18, 2023 •

edited

Loading

✅ Deploy Preview for determined-ui canceled.

Name	Link
🔨 Latest commit	`85d8b7c`
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/6467bfe925df0f00081db2c7

Collaborator

determined-ci commented May 18, 2023

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

determined-ci added documentation shared-web labels

hamidzr requested review from a team and daranday and removed request for salonig23 and a team

May 18, 2023 20:13

Collaborator

determined-ci commented May 18, 2023

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

hamidzr self-assigned this


          Revert "no need to exclude deepspeed"

eae03c9

This reverts commit c775c8d.

hamidzr removed their assignment

Collaborator

determined-ci commented May 18, 2023

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.


          update isort

b49f190

Collaborator

determined-ci commented May 19, 2023

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.


          rename gan module name to mnist

85d8b7c

for some reason isort detects it correctly when its named
gan incorrectly when its named anything else. but it'd be
consistent with other modules

hamidzr force-pushed the precommit-isort branch from a71f563 to 85d8b7c Compare

May 19, 2023 18:28

Collaborator

determined-ci commented May 19, 2023

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

hamidzr assigned daranday

daranday approved these changes

View reviewed changes

Contributor

daranday left a comment

LGTM! As long as all ci tests pass let's land it

Contributor Author

hamidzr commented May 22, 2023

thanks for the review

hamidzr merged commit c60a424 into main

hamidzr deleted the precommit-isort branch

May 22, 2023 18:00

hamidzr restored the precommit-isort branch

May 22, 2023 18:00

hamidzr deleted the precommit-isort branch

May 22, 2023 18:00

wes-turner pushed a commit that referenced this pull request


          chore: add isort pre-commit hook (#6897)

22c771e

upgrade to isort 5.11.5

wes-turner pushed a commit that referenced this pull request


          chore: add isort pre-commit hook (#6897)

60bc257

upgrade to isort 5.11.5

dannysauer added this to the 0.23.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed documentation shared-web