Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace namespace bindings and resource quotas to workspaces #9180

Merged
merged 35 commits into from
Jul 24, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 17, 2024

Ticket

DET-10167

Description

Feature Branch for Workspace Slot Caps Project:

  • Added an API endpoint and CLI command to set workspace namespace bindings.
  • Added an API endpoint and CLI command to delete workspace namespace bindings.
  • Added an API endpoint and CLI command to set resource quotas.
  • Added an API endpoint and CLI command to list namespace bindings.
  • Edited the API endpoint and CLI commands for create and patch workspace to allow setting namespace bindings and resource quotas
  • Added an API endpoint to get the Kubernetes Resource Quotas of the namespaces bound to a workspace.
  • Added an API endpoint to fetch workspace IDs of workspaces with atleast 1 default binding.
  • Added an API endpoint to bulk auto-create workspace namespace bindings for a given set of workspace IDs
  • Added an API endpoint to get the names of Kubernetes Resource Managers.
  • Added a Namespace Bindings section in the Create and Edit Workspace Modals that allows user to set namespace bindings and resource quotas.

Test Plan

Make sure all tests pass

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 17, 2024
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 35613f8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a13f1e1763aa0008e35490
😎 Deploy Preview https://deploy-preview-9180--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.60%. Comparing base (96f1ce4) to head (12ff318).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           stoksc/feat/pods2jobs    #9180       +/-   ##
==========================================================
- Coverage                  51.20%   37.60%   -13.60%     
==========================================================
  Files                        747      175      -572     
  Lines                     110751    29369    -81382     
  Branches                    2779        0     -2779     
==========================================================
- Hits                       56711    11045    -45666     
+ Misses                     53865    18324    -35541     
+ Partials                     175        0      -175     
Flag Coverage Δ
harness 37.91% <ø> (-26.07%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 671 files with indirect coverage changes

@salonig23 salonig23 force-pushed the wksp-namespace-binding branch 2 times, most recently from 8bd1b38 to 445b599 Compare April 23, 2024 19:43
@salonig23 salonig23 marked this pull request as ready for review April 23, 2024 19:48
@salonig23 salonig23 requested review from a team as code owners April 23, 2024 19:48
@salonig23 salonig23 requested review from hamidzr, stoksc, carolinaecalderon and amandavialva01 and removed request for hamidzr April 23, 2024 19:48
@salonig23 salonig23 force-pushed the wksp-namespace-binding branch 5 times, most recently from 1136119 to 3d85dbe Compare April 26, 2024 00:44
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 29, 2024
@determined-ci determined-ci requested a review from a team April 29, 2024 20:49
docs/release-notes/workspace-namespace-binding.rst Outdated Show resolved Hide resolved
docs/release-notes/workspace-namespace-binding.rst Outdated Show resolved Hide resolved
docs/release-notes/workspace-namespace-binding.rst Outdated Show resolved Hide resolved
docs/release-notes/workspace-namespace-binding.rst Outdated Show resolved Hide resolved
master/internal/config/resource_manager_config.go Outdated Show resolved Hide resolved
master/internal/workspace/postgres_workspace.go Outdated Show resolved Hide resolved
master/internal/rm/kubernetesrm/pods.go Outdated Show resolved Hide resolved
master/internal/rm/kubernetesrm/pods.go Outdated Show resolved Hide resolved
master/internal/rm/kubernetesrm/pods.go Outdated Show resolved Hide resolved
amandavialva01 and others added 27 commits July 24, 2024 13:47
Co-authored-by: Saloni Gupta <saloni.gupta@hpe.com>
Co-authored-by: Amanda Vialva <144278621+amandavialva01@users.noreply.github.com>
…ace jobs (#9684)

Ticketed https://hpe-aiatscale.atlassian.net/browse/RM-400 in response to #9684 (review)

We should find a more permanent and reliable solution to cleanly handling resource cleanup in Determined after namespace deletion.
Co-authored-by: Max Russell <max.russell@hpe.com>
@salonig23 salonig23 merged commit 12fc71c into main Jul 24, 2024
79 of 97 checks passed
@salonig23 salonig23 deleted the wksp-namespace-binding branch July 24, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet