Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add selection label to FlatRuns page #9548

Closed
wants to merge 14 commits into from

Conversation

thiagodallacqua-hpe
Copy link
Contributor

@thiagodallacqua-hpe thiagodallacqua-hpe commented Jun 20, 2024

Ticket: ET-309

Description

Add the selection label to the flat runs table.

Test Plan

  • Enable the Flat runs feature
  • go to a runs table
    • there should be a label with the total number of runs
  • make a selection
    • the label should be updated accordingly

Screenshot 2024-06-20 at 15 48 22

Screenshot 2024-06-20 at 15 48 12

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3590c00
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66918f274f3c680008cc763c
😎 Deploy Preview https://deploy-preview-9548--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting and linting code is missing

webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (8379b13) to head (f97962b).
Report is 1 commits behind head on main.

Current head f97962b differs from pull request most recent head 3590c00

Please upload reports for the commit 3590c00 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (8379b13) and HEAD (f97962b). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (8379b13) HEAD (f97962b)
harness 9 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9548      +/-   ##
==========================================
- Coverage   53.01%   46.27%   -6.75%     
==========================================
  Files        1256      929     -327     
  Lines      153021   123048   -29973     
  Branches     3240     3024     -216     
==========================================
- Hits        81129    56941   -24188     
+ Misses      71741    65949    -5792     
- Partials      151      158       +7     
Flag Coverage Δ
harness ?
web 47.96% <0.00%> (-3.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/FlatRuns/FlatRuns.tsx 10.83% <0.00%> (+0.27%) ⬆️

... and 406 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its getting close

webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add tests? (80% or more code cov)

webui/react/src/pages/FlatRuns/FlatRuns.tsx Outdated Show resolved Hide resolved
@johnkim-det
Copy link
Contributor

closing and replacing with #9670

@keita-determined keita-determined deleted the thiago/ET-309 branch July 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants