fix: show selections in ComparisonView on any page (ET-189) #9694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9694 +/- ##
==========================================
- Coverage 53.34% 48.61% -4.73%
==========================================
Files 1255 932 -323
Lines 152723 123636 -29087
Branches 3246 3249 +3
==========================================
- Hits 81464 60102 -21362
+ Misses 71107 63382 -7725
Partials 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashtonG
reviewed
Jul 23, 2024
| selectedExperiments?.length === 0 || selectedRuns?.length === 0 ? ( | ||
| (selectedExperimentIds?.length && selectedExperiments === undefined) || | ||
| (selectedRunIds?.length && selectedRuns === undefined) ? ( | ||
| <Spinner /> |
There was a problem hiding this comment.
remember to ensure the spinner is spinning.
|
|
@ashtonG updated with fix for |
jesse-amano-hpe
added
the
to-cherry-pick
ashtonG
approved these changes
Jul 25, 2024
Comment on lines
60
to
85
| const isSelectionLimitReached = () => { | ||
| if (experimentSelection) { | ||
| if ( | ||
| (experimentSelection.type === 'ONLY_IN' && | ||
| experimentSelection.selections.length > SELECTION_LIMIT) || | ||
| (experimentSelection.type === 'ALL_EXCEPT' && | ||
| total && | ||
| total - experimentSelection.exclusions.length > SELECTION_LIMIT) | ||
| ) { | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
| if (runSelection) { | ||
| if ( | ||
| (runSelection.type === 'ONLY_IN' && runSelection.selections.length > SELECTION_LIMIT) || | ||
| (runSelection.type === 'ALL_EXCEPT' && | ||
| total && | ||
| total - runSelection.exclusions.length > SELECTION_LIMIT) | ||
| ) { | ||
| return true; | ||
| } | ||
| return false; | ||
| } | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
i'm wondering if it's worth doing this vs just looking at the pagination information we get back from the endpoint, especially because the selection object could theoretically contain ids that are no longer in the project.
There was a problem hiding this comment.
ah, that makes sense, will change this to a state boolean that's set based on pagination.total in searchRuns/searchExperiments response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-189
Description
Even if selected experiments/runs are not loaded on the current page, the Compare panel should still fetch data for them.
Test Plan
On Experiments List page (with "New Experiment List" feature flag on):
On Runs List page (with "Flat Runs View" feature flag on):
Checklist
docs/release-notes/See Release Note for details.