Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings first instead of removing method and Bug #92

Closed
Stradivario opened this issue Sep 13, 2018 · 3 comments
Closed

Deprecation warnings first instead of removing method and Bug #92

Stradivario opened this issue Sep 13, 2018 · 3 comments

Comments

@Stradivario
Copy link

Hello there,

I just installed latest typechain version globally and all of my build processes failed!

What is happening is that '--force' argument is deprecated.
Added some --target property for Truffle, web3, legacy

By now i was using legacy and now when i run it it says:

> typechain --target=legacy --outDir src/app/core/contracts './contracts/build/contracts/*.json'

Error occured:  ENOENT: no such file or directory, open '/home/rampage/.nvm/versions/node/v8.9.4/lib/node_modules/typechain/dist/targets/legacy/runtime/typechain-runtime.ts'

I am sure this is not intended ?

So basically i don't have much time to waste and will downgrade typechain to older version.

Please write some CHANGELOG or somewhere inside the REPO what is changed for example it is important if you decide to remove --force to write it somewhere.Thanks

Regards,
K.T.

@Stradivario Stradivario changed the title Deprecation warnings first instead of removing method Deprecation warnings first instead of removing method and Bug Sep 13, 2018
@Stradivario
Copy link
Author

Also when i try to install it globally with NODE 10.^ it is not installing with the same error.

@krzkaczor
Copy link
Member

krzkaczor commented Sep 13, 2018

Thanks for the report. The fix was deployed as typechain@0.3.4, I also added tests that should cover it in future. I would appreciate a note if this solved your problems.

What is happening is that '--force' argument is deprecated.

Typechain 0.3.x is based on ts-generator project. I decided that having --force is not a good option since it should be default settings (and you should never commit generated files etc.). Implementing it in ts-generator would require additional work so I just skipped it. I know that it's a breaking change but very minor one and we still didnt hit 1.0 so it's expected IMO that things like this could happen.

Please write some CHANGELOG or somewhere inside the REPO what is changed for example it is important if you decide to remove --force to write it somewhere.

It's already there :) https://github.com/krzkaczor/TypeChain/blob/master/CHANGELOG.md

I hope that next time updating Typechain will be a smoother process.

@Stradivario
Copy link
Author

Stradivario commented Sep 13, 2018

@krzkaczor awesome man i agree 100% with you !!! I will check for changelogs more carefully next time !!
Thank you very much!
Just for let you know again i love your work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants