Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port/Adapt to Jasmine 2.0 #6

Closed
Jonahss opened this issue Feb 13, 2014 · 6 comments
Closed

Port/Adapt to Jasmine 2.0 #6

Jonahss opened this issue Feb 13, 2014 · 6 comments

Comments

@Jonahss
Copy link

Jonahss commented Feb 13, 2014

Is there a project under-way (or finished) for providing the same functionality for Jasmine 2.0? The reporter interface was completely changed.

@detro
Copy link
Owner

detro commented Feb 14, 2014

No work is planned, but would be lovely if someone was to pick it up.
Are you volunteering? :)

@Jonahss
Copy link
Author

Jonahss commented Feb 14, 2014

Hee hee. I've made a note on my to-do list, but it's not near the top yet ;)

@sclevine
Copy link
Contributor

sclevine commented Mar 7, 2014

Sort of done in #7.

@detro
Copy link
Owner

detro commented Mar 10, 2014

@sclevine while I appreciate the contribution immensely, I must say you haven't done a great job and making me believe it works - or you are just too modest? :)

Because it's essentially a total break with previous Jasmine, I'd appreciate if you couldmake certain those changes work with Jasmine 2.0 and, if possible, preserve all the functionalities.

@sclevine
Copy link
Contributor

Hi @detro,

First, I don't think it's currently possible to count the number of passed expectations per spec in Jasmine 2. @alextreppass made an issue here. We could swap out jasmine.Spec.prototype.addExpectationResult with a function that counted these, but that would be very ugly and fragile.

I'm not going to claim #7 works perfectly without any (automated) tests, but it does seem to generate reasonable output for the test suites I've run it against. I'm more worried about semantics. For instance, Jasmine 2 has disabled and pending statuses, instead of just skipped.

@detro
Copy link
Owner

detro commented Mar 12, 2014

Closing.
Discussion can continue at #7.

@detro detro closed this as completed Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants