Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft: create error handler method #64

Merged

Conversation

kennedymwavu
Copy link
Contributor

Add a method to set the error handler

Closes #63

@JohnCoene
Copy link
Collaborator

Do you mind set_error instead of set_error_handler that would make it more consistent with other methods (e.g.: set_404 set_404_handler).

Also maybe check that the handler is indeed a function (there is an {assertthat} function for that somewhere in the package.

@kennedymwavu
Copy link
Contributor Author

Very sensible. Making the suggested changes.

@kennedymwavu
Copy link
Contributor Author

Don't merge yet... Let me make one more change: Use all() instead of && for backward compatibility.

@kennedymwavu
Copy link
Contributor Author

LGTM now.

@JohnCoene JohnCoene merged commit 0aba170 into ambiorix-web:master Mar 10, 2024
6 of 9 checks passed
@JohnCoene
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a method to set the error handler
2 participants