Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translation for navigate-terminal.md #130

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Add French translation for navigate-terminal.md #130

merged 3 commits into from
Oct 4, 2020

Conversation

iamlordutkarsh
Copy link
Contributor

@iamlordutkarsh iamlordutkarsh commented Oct 4, 2020

Description

I added guide in french language !

Fixes #71

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

note : if there is any issue please tell me i will fix if not and you are going to merge it then please dont forgot to use hacktoberfest-accepted label as they updated rules

Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left a couple comments for small changes to make it ready to merge.

Comment on lines 2 to 6
title: Comment parcourir les fichiers et dossiers sur un terminal
extrait: Ce guide est destiné à vous apprendre les bases de la navigation dans les fichiers et dossiers sur un terminal.
permalien: / guides / navigateur-terminal
permalink_without_prefix: / guides / navigation-terminal
lang: en
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the data keys (for example, excerpt) are standard and don't need to be translated, I recommend updating to this:

layout: guide-layout
title: Comment parcourir les fichiers et dossiers sur un terminal
excerpt: Ce guide est destiné à vous apprendre les bases de la navigation dans les fichiers et dossiers sur un terminal.
permalink: /fr/guides/navigate-terminal
permalink_without_prefix: /guides/navigate-terminal
lang: fr

We also don't translate the guide name in the URL because some languages use characters that don't work in URLs.

i18n/fr/guides/navigate-terminal.md Outdated Show resolved Hide resolved
@devadvance devadvance changed the title Added Guide In french Added Guide In french (navigate-terminal.md) Oct 4, 2020
@devadvance devadvance changed the title Added Guide In french (navigate-terminal.md) Add French translation for navigate-terminal.md Oct 4, 2020
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the excellent translation!

@devadvance devadvance merged commit 7aa676d into devadvance:staging Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a French translation of the navigate terminal guide
2 participants