Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation to 404 page #87

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Add french translation to 404 page #87

merged 1 commit into from
Oct 3, 2020

Conversation

ArnolFokam
Copy link
Contributor

Description

This updates the French translation of the 404 page in 404.html. No apparent issues resulting from the changes were noticed and the amp website validations errors were due to my site run locally over HTTP. Check the image below.
Imgur: terminal

Fixes #80

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Really appreciate this contribution! Thanks validating locally and noting the unrelated errors! 😄

@devadvance devadvance merged commit e035b31 into devadvance:staging Oct 3, 2020
@ArnolFokam ArnolFokam deleted the 404_french_translation branch October 4, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a French translation of the 404 error page
2 participants