Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds french translation for curl rest api guide #131

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Adds french translation for curl rest api guide #131

merged 1 commit into from
Oct 4, 2020

Conversation

ArnolFokam
Copy link
Contributor

Description

I have translated the How to use curl to test a REST API into french. Here are some keynotes of my work:

  • I changed keyboard word Enter to Entrée as that's what is written on most french keyboards (AZERTY)
  • I did not translate code especially those representing JSON data so that it could match what was on the images/GIFs.
  • Jekyll properly served the page.
  • I had no strange validation errors from AMP apart from the ones noticed in my last pull request Add french translation to 404 page #87

Fixes #70

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Fantastic translation! I really appreciate your detailed approach, such as the use of Entrée to match and the image alt attribute translations :) Thanks again for validating locally as well.

@devadvance devadvance merged commit f0b8ca9 into devadvance:staging Oct 4, 2020
@ArnolFokam ArnolFokam deleted the api_guide_translation_FR branch October 5, 2020 05:52
@ArnolFokam
Copy link
Contributor Author

ArnolFokam commented Oct 5, 2020

Looks good to me. Fantastic translation! I really appreciate your detailed approach, such as the use of Entrée to match and the image alt attribute translations :) Thanks again for validating locally as well.

You're welcome @devadvance :) If there is a need for further work on this FR translation. Just notify me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a French translation of the curl REST API guide
2 participants