Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Option<T: DesseStatic + DesseSize> #17

Closed
jrmuizel opened this issue May 10, 2019 · 3 comments
Closed

Support Option<T: DesseStatic + DesseSize> #17

jrmuizel opened this issue May 10, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Dynamically Allocated Types
Milestone
Dynamically Alloc...

Comments

@jrmuizel
Copy link

This would be pretty handy.
@djg
Copy link

djg commented May 10, 2019

I've been trying to implement this and I'm currently stuck on rust-lang/rust#60551

@devashishdxt devashishdxt added enhancement New feature or request good first issue Good for newcomers labels May 17, 2019
@devashishdxt devashishdxt added this to To do in Dynamically Allocated Types via automation May 17, 2019
@devashishdxt
Copy link
Owner

devashishdxt commented May 17, 2019 •
edited

We wont be able to do this without proper support for const generics. Until then, we can figure out a way to implement DesseDynamic trait for Option<T> which will enable de/serialization of Option<T>.

I haven't pushed DesseDynamic trait in master branch as it has a lot of missing pieces. Its currently in desse-dynamic branch.

@devashishdxt
Copy link
Owner

Implemented DesseDynamic for Option<T> in 4a0239b.

Dynamically Allocated Types automation moved this from To do to Done May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Dynamically Allocated Types
  
Done
Milestone
Dynamically Allocated Types
Development

No branches or pull requests
3 participants
@djg @jrmuizel @devashishdxt