Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce executor interface #274

Merged
merged 4 commits into from Jan 18, 2019
Merged

Introduce executor interface #274

merged 4 commits into from Jan 18, 2019

Conversation

mlhamel
Copy link
Collaborator

@mlhamel mlhamel commented Jan 15, 2019 •
edited

Why

Prior to #273

this PR is introducing only the Executor interface, the builder will come next

How

Introducing the Executor interface

@mlhamel mlhamel requested a review from pior as a code owner January 15, 2019 01:29
pior
pior reviewed Jan 16, 2019
View reviewed changes
Copy link
Member

@pior pior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@mlhamel mlhamel merged commit 2caff4b into master Jan 18, 2019
@mlhamel mlhamel deleted the introduce-executor-interface branch January 18, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pior pior pior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mlhamel @pior