Introduce the ExecutorBuilder. #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlhamel
commented
Jan 14, 2019
pkg/executor/executor_builder.go
Outdated
|
|
||
| // ExecutorBuilder build executor with specific program and args | ||
| type ExecutorBuilder interface { | ||
| NewExecutor(program string, args ...string) Executor |
mlhamel
commented
Jan 14, 2019
pkg/executor/executor_builder.go
Outdated
| // ExecutorBuilder build executor with specific program and args | ||
| type ExecutorBuilder interface { | ||
| NewExecutor(program string, args ...string) Executor | ||
| NewShell(cmdline string) Executor |
There was a problem hiding this comment.
or NewExecutorShell ?
mlhamel
commented
Jan 14, 2019
| package executor | ||
|
|
||
| type executorBuilderImpl struct { | ||
| } |
There was a problem hiding this comment.
What do you think of keeping the struct private ?
mlhamel
commented
Jan 14, 2019
| executor.SetOutputPrefix("---") | ||
| result := executor.Run() | ||
| impl := executor.(*executorImpl) | ||
| impl.outputWriter = buf |
There was a problem hiding this comment.
I was searching for a better way but i cannot think of something
There was a problem hiding this comment.
I think this is fine for now. We could improve this by introducing a executor.SetOutputWriter(writer) at some point.
|
The I don't see the big picture about the builder interface... maybe this should be another PR, also including how we use this builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It would be handy to generate executor from the task context: in the future by example we would be able to keep trace of every requested commands.
How
This PR is introducing a set of interfaces for the ExecutorBuilder but also the Executor itself.
Following PR will add the builder into the TaskContext