Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker config with migration on first run #22 #62

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Update docker config with migration on first run #22 #62

merged 1 commit into from
Feb 6, 2019

Conversation

silentworks
Copy link
Member

@silentworks silentworks commented Feb 5, 2019 •
edited

  • docker-compose up now runs migrations
  • expose postgres on port 5433 in order to use visual postgres client

aduwillie
aduwillie reviewed Feb 6, 2019
View reviewed changes
Copy link

@aduwillie aduwillie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But could we consider adding a dockerignore file since we are fixing docker stuffs?

aduwillie
aduwillie reviewed Feb 6, 2019
View reviewed changes
Copy link

@aduwillie aduwillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, we can do without it though.

@yawboakye
Copy link
Member

👍 Thanks @silentworks @aduwillie

@yawboakye yawboakye merged commit 29ccab5 into devcongress:master Feb 6, 2019
@silentworks silentworks deleted the feature/docker-setup branch February 6, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduwillie aduwillie aduwillie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silentworks @yawboakye @aduwillie